Skip to content

Conversation

@Death111
Copy link
Collaborator

@Death111 Death111 commented Jan 13, 2023

Test-branch for a Mac M1:

  • Needs Java 17 as only Java 17 added support for Mac M2 (https://openjdk.org/jeps/391)
  • Deactivated Unit tests as they did not run. Issue was that Controller class instantiates (indirectly) a Timeline-Class (javafx class) which did not work in the pipeline. Not sure if I tested locally.
  • Switched the isLinux() calls to isWindows() as the mac does not identify as isLinux

try with 17.0.2 javafx (not recommended to mix with java 11 target)
@Death111 Death111 marked this pull request as draft January 13, 2023 15:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Death111 Death111 changed the title added javafx-graphics with mac classifier Spring 3 + Mac May 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Death111 Death111 marked this pull request as ready for review January 8, 2025 13:37
@Death111 Death111 requested a review from sesturm January 8, 2025 13:41
- Introduced a static final variable `OS_NAME` to store the lowercased OS name, reducing repeated calls to `System.getProperty()`.
- Updated methods `isWindows()`, `isLinux()`, `getOSName()`, and `isMacOS()` to utilize the new `OS_NAME` variable for improved performance and readability.
- Updated Spring Boot version from 3.1.10 to 3.4.1 for improved features and security.
- Upgraded Maven Dependency Check version from 9.1.0 to 11.1.1 to enhance dependency scanning capabilities.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Death111 Death111 merged commit eab713c into develop Jan 9, 2025
3 of 5 checks passed
@Death111 Death111 deleted the feature/macSupport branch January 9, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants